Updates to secp256k1 signature support #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
10 tasks
|
The kvstore integration test's failing non-deterministically again (first time in ages): Unrelated to the work in this PR. |
tony-iqlusion
approved these changes
Sep 1, 2021
thanethomson
added a commit
that referenced
this pull request
Sep 1, 2021
* Show underlying detail in some signature errors * Add support for Secp256k1 signatures * Represent Signature as a wrapper over a byte array * Cleanup * Fix warning when `secp256k1` feature is disabled * Add .changelog entry * Updates to secp256k1 signature support (#964) * Add fallible constructor for Signature to facilitate TryFrom<&[u8]> Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add Ed25519 test vectors from RFC Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add test vectors for secp256k1 signature validation Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <thane@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #962, incorporating feedback from review.
.changelog/